RFR: 8350398: [s390x] Relativize initial_sp/monitors in interpreter frames

[Lutz Schmidt]

On Wed, 7 May 2025 13:29:05 GMT, Lutz Schmidt <duke at openjdk.org> wrote:

>> src/hotspot/cpu/s390/interp_masm_s390.cpp line 689:
>> 
>>> 687:   stop("Z_fp is corrupted");
>>> 688:   bind(ok);
>>> 689: #endif // ASSERT
>> 
>> Hi @RealLucy, 
>> should I remove or keep this check here ? I wouldn't harm in release build anyway, but for debug build the size of `BTB` table will increase. Look `TemplateTable_s390.cpp` changes.
>
> Well,
> it's a tradeoff between space consumption and code safety. I personally would leave the check in as long as we do not run into space limitations. If you would like to keep the code more compact, and remove the #ASSERT blocks, that's ok for me too.

Sorry,
the above comment was made while I was signed in with my alter ego. Bottom line was: I would keep the code, but if you don't like the code bloat, remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23708#discussion_r2078051508