RFR: 8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix [v2]

Coleen Phillimore coleenp at openjdk.org
Fri May 9 11:42:54 UTC 2025


On Fri, 9 May 2025 08:29:30 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> The `set_flags` function really only sets whether it has an appendix or not, and there's a separate `set_resolution_failed` method just below that also alters the flag. Just rename this to `set_has_appendix`
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Just do the obvious thing

While you're here, resolution_failed should have a named bit as well as has_appendix.
I wonder if you can use C++ bit syntax too since SA doesn't read these flags.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25092#pullrequestreview-2827990742


More information about the hotspot-dev mailing list