RFR: 8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix [v3]

Coleen Phillimore coleenp at openjdk.org
Fri May 9 12:37:34 UTC 2025


On Fri, 9 May 2025 12:19:33 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> The `set_flags` function really only sets whether it has an appendix or not, and there's a separate `set_resolution_failed` method just below that also alters the flag. Just rename this to `set_has_appendix`
>
> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - We missed the case of has_appendix = false
>  - And make the code uniform for both flags

Too bad it can't use c++ bitfield syntax.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25092#pullrequestreview-2828144015


More information about the hotspot-dev mailing list