RFR: 8356173: Remove ThreadCritical

[Coleen Phillimore]

On Fri, 9 May 2025 04:59:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Updated the description in the bug.  This removes the last use of ThreadCritical and replaces it with a global PlatformMutex lock.
>> Tested with tier1-4, and tier1 on all Oracle-supported OSs.
>
> src/hotspot/share/memory/arena.cpp line 219:
> 
>> 217:     pool->return_to_pool(c);
>> 218:   } else {
>> 219:     // Free chunks under NMT lock so that NMT adjustment is stable.
> 
> NMT lock???

This could use an NMT lock instead (had a version with this once).  I fixed the comment to reflect this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25072#discussion_r2081866093