RFR: 8356173: Remove ThreadCritical [v3]
Kim Barrett
kbarrett at openjdk.org
Sat May 10 03:23:52 UTC 2025
On Fri, 9 May 2025 22:06:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> As I said in another comment, Windows appears to require a call to an initialization function. So this seems
>> like a good candidate for Deferred<> to me, removing some relatively boiler-plate code.
>
> I'm not really sold on what the purpose of Deferred is tbh. Seems like it would add some more boilerplate since I the initialization function is only one obvious line.
The initialization lines are similar one-liners.
Deferred<> access already had the initialized check built-in, so don't need the explicit assert.
Deferred<> avoids the pointer indirection.
Deferred<> avoids dynamic allocation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25072#discussion_r2082791117
More information about the hotspot-dev
mailing list