RFR: 8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix [v4]
David Holmes
dholmes at openjdk.org
Mon May 12 02:19:01 UTC 2025
On Mon, 12 May 2025 02:06:12 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Hmmm so the complex machinations is not really about "preserving the other bits".
>
> I was assuming the only possibility is to go from no-appendix to having-an-appendix
Anyway yes we need the original logic, which for the sake of completeness creates `old_flags` such that the appendix bit is zero, and all other bits are preserved, and we then OR with `new_flags` that only has the appendix bit ever set and thus it determines the final value of the appendix bit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25092#discussion_r2083715495
More information about the hotspot-dev
mailing list