RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v14]

[Ioi Lam]

On Tue, 13 May 2025 03:32:13 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> src/hotspot/share/cds/filemap.cpp line 1955:
>> 
>>> 1953:                     " does not equal the current SpecTrapLimitExtraEntries setting (%d).", file_type,
>>> 1954:                     _spec_trap_limit_extra_entries, SpecTrapLimitExtraEntries);
>>> 1955:       return false;
>> 
>> The `log_info(cds)` should be replaced with `MetaspaceShared::report_loading_error`.  (The few `log_info` lines above this block will be fixed in [JDK-8356807](https://bugs.openjdk.org/browse/JDK-8356807))
>> 
>> Also, could you add a new jtreg test case for this? You can see examples in `negativeTests` in the existing AOTFlags.java test case. I think you can add your checks into the new AOTProfileFlags.java test.
>
> Do you want me to leave the existing `log_info` alone? Or should I fix everything in `FileMapHeader::validate()` ?

You can leave the existing code and just fix the new code you added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2086143903