RFR: 8356595: Convert -Xlog:cds to -Xlog:aot [v3]

David Holmes dholmes at openjdk.org
Tue May 13 08:56:56 UTC 2025


On Tue, 13 May 2025 08:34:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More conversion; clean up; bug fixes
>
> src/hotspot/share/cds/aotLogging.hpp line 146:
> 
>> 144:       LogTagSetMapping<LogTag::_aot, T1, T2, T3, T4>::tagset().vwrite(level, fmt, args);
>> 145:     }
>> 146:   }
> 
> ```suggestion if possible
>     LogTag tag =  PrintAOTLogsAsCDSLogs ? LogTag::_cds : LogTag::_aot;
>     LogTagSetMapping<tag, T1, T2, T3, T4>::tagset().vwrite(level, fmt, args);
>   }

Given templates, I'm not sure the above is actually possible. And it is pseudo-code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2086290011


More information about the hotspot-dev mailing list