RFR: 8356173: Remove ThreadCritical [v5]

[Kim Barrett]

On Tue, 13 May 2025 11:58:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Updated the description in the bug.  This removes the last use of ThreadCritical and replaces it with a global PlatformMutex lock.
>> Tested with tier1-4, and tier1 on all Oracle-supported OSs.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Camel case for global lock variable.

Looks good.

src/hotspot/share/memory/arena.cpp line 43:

> 41: // code and other areas.  For many calls, the current thread has not
> 42: // been created so we cannot use Mutex.
> 43: static PlatformMutex* GlobalChunkPoolMutex = nullptr;

That naming style also seems consistent with some of the code base and with the style guide.  So okay.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25072#pullrequestreview-2837833933
PR Review Comment: https://git.openjdk.org/jdk/pull/25072#discussion_r2087459724