RFR: 8356875: RISC-V: extension flag UseZvfh should depends on UseZfh
Fei Yang
fyang at openjdk.org
Wed May 14 14:32:50 UTC 2025
On Tue, 13 May 2025 13:53:35 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this simple patch?
> If we don't enable such dependency, then there will be situation that when Zvfh is enabled but Zfh is disabled, and optimizations depending on Zvfh will be disabled (e.g. in C2) because Zfh related IR node are considered not supported.
>
> Thanks!
>
> By [rvv spec](https://github.com/riscvarchive/riscv-v-spec/blob/master/v-spec.adoc#185-zvfh-vector-extension-for-half-precision-floating-point), `The Zvfh extension depends on the Zve32f and Zfhmin extensions.`
> But I think in logic and JVM code, we should let `Zvfh` depends on `Zfh`.
Looks good. Thanks.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25213#pullrequestreview-2840449699
More information about the hotspot-dev
mailing list