RFR: 8337789: JEP 509: JFR CPU-Time Profiling (Experimental) [v47]

[Johannes Bechberger]

On Mon, 12 May 2025 17:57:35 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify local trace stack
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 107:
> 
>> 105:   JavaThread* jt;
>> 106: 
>> 107:   if (raw_thread == nullptr || !raw_thread->is_Java_thread() ||
> 
> Why would raw_thread be nullptr? I see we add the timer after the JavaThread has been initialized and we remove it before the JavaThread is deleted. Also we only create the timer for JavaThreads already, so these look like they should be asserts.

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r2091199711