RFR: 8353638: C2: deoptimization and re-execution cycle with StringBuilder [v2]

[Marc Chevalier]

On Thu, 15 May 2025 13:23:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spaces
>
> src/hotspot/share/runtime/globals.hpp line 655:
> 
>> 653:   product(bool, DeoptimizeOnAllocationException, false, DIAGNOSTIC,          \
>> 654:           "Deoptimize on exception during allocation instead of using the"  \
>> 655:           " compiled exception handlers")                                   \
> 
> For consistency with other flag definitions:
> Suggestion:
> 
>   product(bool, DeoptimizeOnAllocationException, false, DIAGNOSTIC,         \
>           "Deoptimize on exception during allocation instead of using the " \
>           "compiled exception handlers")                                    \

Indeed, it was a bit ugly. I think I have my spaces in row now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25149#discussion_r2092538365