RFR: 8351958: Some compile commands should be made diagnostic [v2]

[Tobias Hartmann]

On Fri, 16 May 2025 12:08:00 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 51:
>> 
>>> 49:  * @summary Warn if compile command that is an alias for a diagnostic vm option is used and -XX:+UnlockDiagnosticVMOptions isn't specified.
>>> 50:  * @requires vm.flagless
>>> 51:  * @requires ! vm.debug
>> 
>> Suggestion:
>> 
>>  * @requires !vm.debug
>
> I think it's nicer indeed. I've kept it this way for consistency, but I don't mind making it nicer. Should I also fix the lines 29, 40 and 62 that have such a space?

Yes, feel free to do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25150#discussion_r2093013204