RFR: 8345826: Do not automatically resolve jdk.internal.vm.ci when libgraal is used [v2]

[Doug Simon]

On Fri, 16 May 2025 13:48:45 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   resolve jdk.internal.vm.ci if +EnableJVMCI and -UseJVMCINativeLibrary
>
> src/hotspot/share/runtime/arguments.cpp line 1814:
> 
>> 1812:     }
>> 1813:     PropertyList_unique_add(&_system_properties, "jdk.internal.vm.ci.enabled", "true",
>> 1814:         AddProperty, UnwriteableProperty, InternalProperty);
> 
> What's the purpose of the `jdk.internal.vm.ci.enabled` property? Should it be enabled only if the `jdk.internal.vm.ci` module is added?

It exists to [check](https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20checkJVMCIEnabled&type=code) in various Java-level entry points that the JVMCI VM support has been enabled so a nicer error message can be thrown that provides a possible corrective action. However, since it's now impossible to load the JVMCI module without enabling the JVMCI VM support, this is no longer of any use. I'll remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25240#discussion_r2093162767