RFR: 8338977: Parallel: Improve heap resizing heuristics [v2]

Guoxiong Li gli at openjdk.org
Sun May 18 12:45:58 UTC 2025


On Fri, 16 May 2025 07:50:13 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp line 179:
>> 
>>> 177:     _gc_distance_timer.reset();
>>> 178:     _gc_distance_timer.start();
>>> 179:   }
>> 
>> The method name `record_gc_pause_end_instant` is about `gc pause`, but the code is about `gc distance`. May we need a clearer name?
>
> In stw-gc, when a gc-pause ends, mutators start running, so the distance btw two consecutive gc-pauses start to tick. This looks quite clear to me, but I am ofc biased. What names do you suggest?

I don't have a better name now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25000#discussion_r2094513461


More information about the hotspot-dev mailing list