RFR: 8355481: Clean up MHN_copyOutBootstrapArguments [v4]

Johan Sjölen jsjolen at openjdk.org
Mon May 19 08:17:59 UTC 2025


On Fri, 9 May 2025 11:44:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add an assert
>
> src/hotspot/share/prims/methodHandles.cpp line 1260:
> 
>> 1258:       THROW_MSG(vmSymbols::java_lang_InternalError(), "bad index info (1)");
>> 1259:   }
>> 1260:   objArrayHandle buf(THREAD, (objArrayOop) JNIHandles::resolve(buf_jh));
> 
> Do you want to assert about the value of 'start'  and 'end'?  This became a nice cleanup.

Yes, we do!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24825#discussion_r2095119572


More information about the hotspot-dev mailing list