Integrated: 8355481: Clean up MHN_copyOutBootstrapArguments

[Johan Sjölen]

On Wed, 23 Apr 2025 11:27:21 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Edit: **This code is dead** and we're deleting it, I've kept the original PR description so that following the Github conversation below is easier.
> 
> Hi,
> 
> I'd like to integrate this simplification of the code for this loop.
> 
> We used to have:
> 
> ```c++
> if (start < 0) {
>   for (int pseudo_index = -4; pseudo_index < 0; pseudo_index++) {
>     if (start == pseudo_index) {
>       if (start >= end || 0 > pos || pos >= buf->length())  break;
>       // ...
>     }
>     start++;
>   }
> }
> 
> 
> That's exactly the same as:
> 
> 
> int min_end = MIN2(0, end);
> while (-4 <= start && start < min_end) {
>   if (pos >= buf->length()) break;
>   // ...
>   start++;
> }
> 
> 
> but the latter looks like a conventional loop.
> 
> I'd consider this a basic cleanup, which is worth doing in the name of maintainability.
> 
> I would have liked to change the `-4` to `-1` into actual names, but I've no clue where those come from. It doesn't seem worth it to change them if they just happen to be a kludge relying on internal details, or something like that.
> 
> Testing: GHA Tier1

This pull request has now been integrated.

Changeset: 133c6fb4
Author:    Johan Sjölen <jsjolen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/133c6fb4f34e9de3ffce92e10629c82f6723fcdd
Stats:     50 lines in 1 file changed: 3 ins; 45 del; 2 mod

8355481: Clean up MHN_copyOutBootstrapArguments

Reviewed-by: dholmes, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/24825