RFR: 8356372: JVMTI heap sampling not working properly with outside TLAB allocations [v4]

[Stefan Karlsson]

On Mon, 19 May 2025 09:40:47 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into 8356372_thread_heap_sampler
>>  - Tweak names
>>  - Fix sample threshold setup
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
>>  - Re-enable tests after merge
>>  - Merge remote-tracking branch 'upstream/master' into 8356372_thread_heap_sampler
>>  - 8356372: JVMTI heap sampling not working properly with outside TLAB allocations
>
> Stefan, thank you for the update. The whole fix looks good in general. I like the refactoring.
> One comment still need an update though as it has a removed/renamed field name.

Thanks, @sspitsyn! I think I've addressed all your comments now except making the names shorter. I hope that's OK and if we really want to shorten then, I don't mind doing it in a follow-up RFE.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25114#issuecomment-2890697415