RFR: 8356998: Convert -Xlog:cds to -Xlog:aot (step 2) [v4]

Matias Saavedra Silva matsaave at openjdk.org
Mon May 19 20:43:52 UTC 2025


On Thu, 15 May 2025 03:10:37 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is the second step that follows #25136. Most of the changes are mechanical.
>> 
>> - Compatible Logs are changed to `aot_log_xxx(aot, ...)`
>> - All other logs are changed to `log_xxx(cds, ...)`
>> 
>> All `-Xlog:cds` logs are converted, except for `-Xlog:cds+dynamic`, because:
>> 
>> - Dynamic archive is supported only in the old CDS workflow. It's not supported in the new AOT workflow.
>> - Changing it to `-Xlog:aot+dynamic` is inappropriate. Perhaps we should change it to `-Xlog:aot+cds+dynamc+archive`. However, that will affect a lot of test cases. We'll leave this for JDK 26.
>> 
>> 
>> Additional changes:
>> 
>> - There are some changes in the test cases to match the new log output.
>> - I also changed a few log messages when the distinction of "shared archive" vs "AOT cache" is significant.
>> - Makefile change for `-Xlog:cds+map` -> `-Xlog:aot+map`
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed one missed log_info(cds)

LGTM!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25238#pullrequestreview-2851949704


More information about the hotspot-dev mailing list