RFR: 8344270: Update tier1_common and hotspot_misc groups to better organize hotspot non-component tests

[Leonid Mesnik]

On Mon, 19 May 2025 20:31:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Can you please review following PR that improve test groups.
>> The bug was originally filed  to eliminate duplication between tier1_common and hotspot_misc test groups.  However while looked on the test content of these groups I realized that there are some other issues. 
>> 1) hotspot_resourcehogs groups should be executed always separately from other tests to don't cause intermittent failures.
>> 2) it makes sense to run all gtest tests in tier1 but don't run in any other tiers (with any VM flags) 
>> 3) testlibrary_tests and  sources should be a separate groups that don't need to be executed with any VM flags, or event with all builds 
>> 
>> So tier1_common includes non-component tests that should be executed in tier1. 
>> **all** sanity tests
>> **all** gttest tests (were not all of them)
>> testlibrary_tests (might be os/cpu specifc, so need to run them with all builds)
>> source code checking tests (no need to run them an all builds, but it takes only few seconds)
>> 
>> And it doesn't makes any sense to execute  tier1_common with any external VM flags.
>> 
>> While hotspot_misc now includes on 2 sanity tests.  It doesn't looks useful, but main purpose for this group would be to catch all tests that somehow missed from other groups. So let keep it. 
>> 
>> The new test groups were added mostly to add comments explaining their specific.
>
> test/hotspot/jtreg/TEST.groups line 36:
> 
>> 34: 
>> 35: hotspot_all = \
>> 36:   -:hotspot_resourcehogs \
> 
> When "all" was defined it was specifically intended to be all. If you want all-but-something then you define a group that is all-but -something. I don't know if these groups even get used regularly by anyone.

There is a problem with resource_hogs, it is a specific group that might affect any other tests. It is not safe to execute :hotspot_resourcehogs with any other tests. I think that we don't have this problem know or we might have just rare intermittent failures/timeouts of random tests. 
Do we need any groups that are potentially unsafe at all? I don't think so and consider these tests like '/manually' that should be automatically ignored .

> test/hotspot/jtreg/TEST.groups line 165:
> 
>> 163:   sanity \
>> 164:   native_sanity \
>> 165:   :non_hotspot_tests \
> 
> Why should we want to execute the non-hotspot-tests in tier1 ??

That's a good question. These tests are executed now in tier1. They include source verification and test library tests. We could introduce tier2_common for them, do you want to do it in this RFE?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2096482620
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2096493630