RFR: 8356998: Convert -Xlog:cds to -Xlog:aot (step 2) [v4]
Ioi Lam
iklam at openjdk.org
Mon May 19 23:07:53 UTC 2025
On Mon, 19 May 2025 21:50:24 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed one missed log_info(cds)
>
> src/hotspot/share/cds/archiveUtils.cpp line 282:
>
>> 280: void DumpRegion::print_out_of_space_msg(const char* failing_region, size_t needed_bytes) {
>> 281: aot_log_error(aot)("[%-8s] " PTR_FORMAT " - " PTR_FORMAT " capacity =%9d, allocated =%9d",
>> 282: _name, p2i(_base), p2i(_top), int(_end - _base), int(_top - _base));
>
> Please fix the indentation of line 282.
Many lines are now out of alignment. I didn't change any of such lines to avoid introducing massive diffs. Also, in a short time (maybe in 6 months) we will change these from `aot_log_xxx(aot)` back to `log_xxx(aot)` :
log_error(aot)("[%-8s] " PTR_FORMAT " - " PTR_FORMAT " capacity =%9d, allocated =%9d",
and I don't want to redo all the line alignments again.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25238#discussion_r2096589798
More information about the hotspot-dev
mailing list