RFR: 8356998: Convert -Xlog:cds to -Xlog:aot (step 2) [v7]
Calvin Cheung
ccheung at openjdk.org
Tue May 20 04:56:53 UTC 2025
On Tue, 20 May 2025 04:21:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> This is the second step that follows #25136. Most of the changes are mechanical.
>>
>> - Compatible Logs are changed to `aot_log_xxx(aot, ...)`
>> - All other logs are changed to `log_xxx(cds, ...)`
>>
>> All `-Xlog:cds` logs are converted, except for `-Xlog:cds+dynamic`, because:
>>
>> - Dynamic archive is supported only in the old CDS workflow. It's not supported in the new AOT workflow.
>> - Changing it to `-Xlog:aot+dynamic` is inappropriate. Perhaps we should change it to `-Xlog:aot+cds+dynamc+archive`. However, that will affect a lot of test cases. We'll leave this for JDK 26.
>>
>>
>> Additional changes:
>>
>> - There are some changes in the test cases to match the new log output.
>> - I also changed a few log messages when the distinction of "shared archive" vs "AOT cache" is significant.
>> - Makefile change for `-Xlog:cds+map` -> `-Xlog:aot+map`
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 41 commits:
>
> - Merge branch 'master' into 8356010-convert-cds-log-to-aot-log-part2
> - Fixed merge
> - @calvinccheung comments
> - Merge branch '8356595-convert-cds-log-to-aot-log' into 8356010-convert-cds-log-to-aot-log-part2
> - Fixed merge
> - Merge branch 'master' into 8356595-convert-cds-log-to-aot-log
> - @jdksjolen review comments
> - Fixed one missed log_info(cds)
> - Merge branch '8356595-convert-cds-log-to-aot-log' into 8356010-convert-cds-log-to-aot-log-part2
> - Merge master
> - ... and 31 more: https://git.openjdk.org/jdk/compare/7077535c...9339f9c3
Marked as reviewed by ccheung (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25238#pullrequestreview-2852608514
More information about the hotspot-dev
mailing list