RFR: 8354969: Add strdup function for ResourceArea [v5]

Anton Artemov duke at openjdk.org
Tue May 20 08:04:35 UTC 2025


On Mon, 19 May 2025 02:03:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thanks, if I understand what TRAPS is and how it works correctly, reducing to a single thread-taking method would require multiple changes in multiple source files, just to propagate TRAPS -> THREAD sequences to the right place. I think it is better just to have 2 methods.
>
> What I am suggesting is:
> 
>   char* rfilename = ResourceArea::strdup(THREAD, filename);
>   char* robjectname = ResourceArea::strdup(THREAD, objectname);

Right, I misunderstood. In this particular case yes, it makes sense. I addressed it in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24998#discussion_r2097260323


More information about the hotspot-dev mailing list