RFR: 8317453: NMT: Performance benchmarks are needed to measure speed and memory [v10]

[Johan Sjölen]

On Wed, 7 May 2025 15:12:42 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/hotspot/share/nmt/memLogRecorder.hpp line 185:
>> 
>>> 183: 
>>> 184: class NMT_MemoryLogRecorder : public NMT_LogRecorder {
>>> 185: public:
>> 
>> TODOs?
>
> There is a bunch of TODOs for Windows impl. I am hoping we can check it in without Windows support, then add that later?

That's fine, but it'd be good to have a comment on top of this code mentioning why we are duplicating these classes ("because we're not implementing for Windows right now")

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23786#discussion_r2097418115