RFR: 8356159: RISC-V: Add Zabha [v3]
Robbin Ehn
rehn at openjdk.org
Tue May 20 12:37:07 UTC 2025
On Tue, 20 May 2025 12:29:39 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> This adds the byte and halfword atomic memory operations (Zabha) - https://github.com/riscv/riscv-zabha.
>> All amo-instructions, except load-reserve and store-conditional, can also be performed on natural aligned half-words and bytes. (i.e. the extension do not add lr.h/b or sc.h/b) This includes amocas if zacas extension is present.
>>
>> The majority of this patch is to support amocas.h/b. We are now starting to really feel the pain of all these extensions, as CAS:ing 16/8-bits can now be done in three different ways:
>> - lr.w/sc.w 'narrow' CAS (no extension)
>> - amocas.w 'narrow' CAS (Zacas)
>> - amocas.h/b (Zacas + Zabha)
>>
>> There is no hwprobe support yet.
>>
>> Ran t1-3 with Zacas+Zabha and t1 without Zabha in qemu.
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Bug and review fixes
> - Merge branch 'master' into 8356159
> - Revert back to default relaxed
> - Merge branch 'master' into 8356159
> - Fixed ws
> - Initial draft
I think I got all. I also took the oppertunity to change the default on lr/sc as we don't use the default.
"aqrl" is a much safer default, using relaxed should be explicit IMHO.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25252#issuecomment-2894241767
More information about the hotspot-dev
mailing list