RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

Johan Sjölen jsjolen at openjdk.org
Thu May 22 17:55:07 UTC 2025


On Thu, 22 May 2025 17:52:41 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>>  The constant pool currently has a lot of methods specific to extracting parts of the operands array. What this array actually is, is a sequence of bootstrap method attribute entries, where each entry has the following components:
>> 
>> ```c++
>> struct BSMAE {
>>   u2 bootstrap_method_index;
>>   u2 argument_count;
>>   u2 arguments[argument_count];
>> }
>> 
>> 
>> We can removes some of these operands array specific methods, and instead allows you to extract BSMAttributeEntrys which you can then use to extract its piece wise components. This makes for a nicer interface, and a bit easier to come into as a reader of the code, as it more closely mirrors the JVMS. 
>> 
>> Please consider!
>> 
>> Testing: Currently GHA, running tier1-tier3
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Lois's comments

Thank you for the review Lois! I've addressed most of your comments, but I didn't add any documentation for the `BSMAttributeEntry` (yet).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25298#pullrequestreview-2862094950


More information about the hotspot-dev mailing list