RFR: 8357402: Crash in AdapterHandlerLibrary::lookup

[Ashutosh Mehra]

On Thu, 22 May 2025 19:31:22 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> I think that should not be happening. Can you please create a new issue for this with more details and I can try to see why is that the case.
>
> The number of cached adapters and performance improvement are still here:
> 
> $ (perf stat -r 100 ./build/product/images/jdk/bin/java -XX:AOTCache=app.aotcache -XX:+UnlockDiagnosticVMOptions -XX:+AOTAdapterCaching -cp hello.jar HelloWorld > /dev/null) 2>&1 | grep elapsed
>          0.0247033 +- 0.0000319 seconds time elapsed  ( +-  0.13% )
> 
> vs w/o AOT adapters:
>          0.0266180 +- 0.0000352 seconds time elapsed  ( +-  0.13% )

Yeah, they would still be cached, but now that the link from Method-->AdapterHandlerEntry is broken, it would be established by a lookup in the archived adapter table. If this link is maintained, then the lookup for archived adapters won't be needed. Ideally we want to preserve the graph of metadata objects as much as possible. If for some reason we cannot preserve this link, then we can fallback to looking up the adapters in the table.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25398#discussion_r2103300095