RFR: 8323497: On x64, use 32-bit immediate moves for narrow klass base if possible [v7]

Aleksey Shipilev shade at openjdk.org
Fri May 23 08:26:38 UTC 2025


On Fri, 23 May 2025 08:15:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - also for encode_klass
>>  - fix test
>>  - back to unconditional 4g, but with better comment
>>  - feedback alexey
>
> src/hotspot/cpu/x86/compressedKlass_x86.cpp line 30:
> 
>> 28: #include "oops/compressedKlass.hpp"
>> 29: #include "utilities/globalDefinitions.hpp"
>> 30: #include "memory/metaspace.hpp"
> 
> `make test TEST=sources/` would likely complain about unsorted order.

Ah no, it only checks this directories:


    private static final String[] HOTSPOT_SOURCES_TO_CHECK = {
                    "share/c1",
                    "share/ci",
                    "share/compiler",
                    "share/jvmci",
    };


Still worthwhile to sort the includes right here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17340#discussion_r2104075772


More information about the hotspot-dev mailing list