RFR: 8323497: On x64, use 32-bit immediate moves for narrow klass base if possible [v8]

Roman Kennke rkennke at openjdk.org
Fri May 23 16:05:58 UTC 2025


On Fri, 23 May 2025 08:26:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> On x64, we always use the long form of mov immediate to load the klass base into a register. If the klass base fits into 32 bits, we could use the short form and save four instruction bytes. 
>> 
>> Before: mov uses 10 instruction bytes:
>> 
>> 
>>    35  ;; decode_klass_not_null
>>    36   0x00007f8b089e51c4:   movabs $0x82000000,%r11
>>    37   0x00007f8b089e51ce:   add    %r11,%r10
>> 
>> 
>> Now: mov uses 6 instruction bytes:
>> 
>> 
>>    35  ;; decode_klass_not_null
>>    36   0x00007fbe609e51c4:   mov    $0x82000000,%r11d
>>    37   0x00007fbe609e51ca:   add    %r11,%r10
>> 
>> 
>> Note that this optimization does not depend on zero-based addressing, and therefore we change class space reservation: we now always look in low-address regions first.
>> 
>> ----------
>> 
>> Tests: tier1 (GHA), tier 2 on x64 linux
>
> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Alexey feedback 2,5
>  - Alexey feedback 2

Marked as reviewed by rkennke (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17340#pullrequestreview-2864941180


More information about the hotspot-dev mailing list