RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v5]
Johannes Bechberger
jbechberger at openjdk.org
Sun May 25 20:51:56 UTC 2025
On Sun, 25 May 2025 20:30:50 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix compilation
>
> src/hotspot/share/jfr/support/jfrThreadLocal.hpp line 378:
>
>> 376:
>> 377: void unset_cpu_timer() {
>> 378: _has_cpu_timer = false;
>
> Do we really need a separate bool to understand whether the thread has a timer? Can't that information be deduced from the timer_t?
Do we want to make hard assumptions on timer_t?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106303634
More information about the hotspot-dev
mailing list