RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps

[Alan Bateman]

On Tue, 27 May 2025 09:48:04 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> 1. Did you consider putting this implementation in another file, say threadServices.hpp or even its own file? I'm asking because javaClasses seems to have become a dumping ground for code that calls from Java code into the JVM. It would be nice if we could put features into files that are named after the feature.

Alex can correct me but I think it started out here because of java_lang_Thread::async_get_stack_trace/GetStackTraceClosure. It has gone through a number of iterations and you are probably right that it would be better off in threadService or its own source file now.

> 2. Did you consider to put these OopHandle storages in something else than Universe::vm_globals()? We have, for example, ThreadService::_thread_service_storage.

That OopStorage is maintained in threadService.cpp so would be an option if the code moves.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25425#issuecomment-2912183841