RFR: 8357626: RISC-V: Tighten up template interpreter method entry code [v3]
Anjian Wen
wenanjian at openjdk.org
Wed May 28 08:23:09 UTC 2025
On Wed, 28 May 2025 07:46:32 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Anjian Wen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add comments
>
> src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 806:
>
>> 804:
>> 805: // Save ConstantPool* in t3_constants for later use to avoid loading multiple times
>> 806: Register t3_constants = t3;
>
> Can you rename this as `x28_constants`? Like: `Register x28_constants = x28;`
Thanks for review! good suggestion, fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25412#discussion_r2111244842
More information about the hotspot-dev
mailing list