RFR: 8356949: AArch64: Tighten up template interpreter method entry code [v3]

[Aleksey Shipilev]

On Wed, 28 May 2025 08:27:10 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Style updates
>
> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 905:
> 
>> 903:   // Save ConstantPool* in r11_constants for later use to avoid loading multiple times
>> 904:   Register r11_constants = r11;
>> 905:   const Register r11 = noreg;
> 
> I understand the motivation here, but I really wouldn't want to see this practice deployed any further across the AArch64 back end. I have to read a _lot_ of code in `cpu/aarch64`, and it's confusing enough already. :-)
> Rather that this, you could just use another register from the dozen or so that are free.

You mean putting `noreg` into `r11`? Yeah, this can go away, it was off-the-cuff suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25312#discussion_r2111267933