RFR: 8356548: Avoid using ASM to parse latest class files in tests [v4]

[David Holmes]

On Fri, 9 May 2025 22:34:45 GMT, Chen Liang <liach at openjdk.org> wrote:

>> For early eval; test by changing the ClassReader max accepted version of test ASM to 24 instead of 25
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Move other tier 4,5, etc tests to not use ClassReader
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - Use classfile api instead of javac setting version
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/asm-test-upgrade
>  - 8356548: Avoid using ASM to parse latest class files in tests

I do not know either ASM or the Classfile API in great depth so evaluating the conversion is difficult. That said it looks reasonable.

How have you validated the conversion process? Did you check that the Classfile API generated files match the ASM versions? I can imagine it would be very easy to make a mistake in the conversion process and still have the tests pass.

Thanks

-------------

PR Review: https://git.openjdk.org/jdk/pull/25124#pullrequestreview-2876764761