RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

[Alan Bateman]

On Thu, 29 May 2025 03:26:49 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> This is first (hotspot) part of the update for `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify reviewing.
>> The fix contains an implementation of `jdk.internal.vm.ThreadSnapshot` class to gather required information about a thread.
>> Second (dependent) part includes changes in `HotSpotDiagnosticMXBean.dumpThreads`/`jcmd Thread.dump_to_file`, spec updates and tests for the functionality.
>> 
>> Testing: new `HotSpotDiagnosticMXBean.dumpThreads`/`jcmd Thread.dump_to_file` functionality was tested in loom repo;
>>   sanity tier1 (this fix only)
>
> Alex Menkov has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - removed retry_handshake logic
>  - removed AbstractOwnableSynchronizer.exclusiveOwnerThread support
>  - cleanup
>  - renamed java_thread, thread_h
>  - fixed minimal and zero

src/hotspot/share/services/threadService.cpp line 1296:

> 1294:     }
> 1295: 
> 1296:     bool walk_cont = (_java_thread != nullptr) && (_java_thread->vthread_continuation() != nullptr);

Can you double check this? It looks like the refactor has changed something here and this will now walk the continuation when taking a snapshot of a carrier.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113371681