RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Thu May 29 08:09:55 UTC 2025


On Wed, 28 May 2025 07:35:55 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1160:
> 
>> 1158: 
>> 1159:     Type _type;
>> 1160:     OopHandle _obj;
> 
> Nit: Short comments for `_depth` and `_obj` fields (lines: 1142, 1144, 1160) would be nice to have.

Nit: A comment, similar to the one at line 1145 would be nice to have.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113425437


More information about the hotspot-dev mailing list