RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

[Alan Bateman]

On Thu, 29 May 2025 08:01:00 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> src/hotspot/share/services/threadService.cpp line 1296:
>> 
>>> 1294:     }
>>> 1295: 
>>> 1296:     bool walk_cont = (_java_thread != nullptr) && (_java_thread->vthread_continuation() != nullptr);
>> 
>> Can you double check this? It looks like the refactor has changed something here and this will now walk the continuation when taking a snapshot of a carrier.
>
> The logic is the same as before.
> The problem is the variable name. it's `bool vthread_carrier` argument of vframeStream ctor. Will change the name

Something isn't right here. Are you sure walk_cont is correctly for the mounted virtual thread case? There are several tests failing now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113448843