RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

[Alex Menkov]

On Thu, 29 May 2025 07:57:57 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - removed retry_handshake logic
>>  - removed AbstractOwnableSynchronizer.exclusiveOwnerThread support
>>  - cleanup
>>  - renamed java_thread, thread_h
>>  - fixed minimal and zero
>
> src/hotspot/share/services/threadService.cpp line 1143:
> 
>> 1141:     };
>> 1142: 
>> 1143:     int _depth;
> 
> Nit: I'm thinking if `_depth` can be renamed to `_frame_depth`.
> Then it will be self-explained, so no comment is needed.

done

> src/hotspot/share/services/threadService.cpp line 1178:
> 
>> 1176:   GrowableArray<int>* _bcis;
>> 1177:   JavaThreadStatus _thread_status;
>> 1178:   OopHandle _name;
> 
> Nit: Maybe rename is to `_thread_name` or `_tname`.

yes, forgot about it. done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2114492455
PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2114493602