RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

[Alex Menkov]

On Thu, 29 May 2025 08:53:44 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Let's check the logic before and now:
>>  - before:
>>    `walk_cont = _java_thread != nullptr && !is_virtual && _thread->vthread_continuation() != nullptr`
>>  - now:
>>    `walk_cont = _java_thread != nullptr && _thread->vthread_continuation() != nullptr`
>>  
>>  Alan's concern is that the check for  `!is_virtual` is missed now.
>>  I'm not sure yet if it created a problem but the logic is a bit different.
>
> If renamed to bool vthread_carrier then it will be clearer to see that the logic isn't right now. It should only be true when !is_virtual and there is a mounted virtual thread.

Right, thanks for catching. Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2114496019