RFR: 8357086: os::xxx functions returning memory size should return size_t [v3]
Anton Artemov
duke at openjdk.org
Fri May 30 08:24:42 UTC 2025
On Wed, 28 May 2025 12:24:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8357086: Fixed formatting.
>
> src/hotspot/share/gc/shared/gcInitLogger.cpp line 66:
>
>> 64: void GCInitLogger::print_memory() {
>> 65: size_t memory = os::physical_memory();
>> 66: log_info_p(gc, init)("Memory: %zu" "%s",
>
> Suggestion:
>
> log_info_p(gc, init)("Memory: %zu%s",
Thanks, addressed in the latest commit.
> src/hotspot/share/gc/z/zLargePages.cpp line 34:
>
>> 32: pd_initialize();
>> 33:
>> 34: log_info_p(gc, init)("Memory: %zu" "M", os::physical_memory() / M);
>
> Suggestion:
>
> log_info_p(gc, init)("Memory: %zuM", os::physical_memory() / M);
Thanks, addressed in the latest commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2115386991
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2115387170
More information about the hotspot-dev
mailing list