RFR: 8371093: Assert "section header string table should be loaded" failed on debug VM

Paul Hübner phubner at openjdk.org
Tue Nov 4 12:50:36 UTC 2025


On Tue, 4 Nov 2025 12:18:16 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> > would it be worth to add an else clause to your if, in which we assert that filepath does not contain vdso or linux-gate.so?
> 
> It would be false-positive if "vdso" is included unintended path like "libfoo-vdsoon.so" . `linux-gate.so` is for unsupported platform of OpenJDK e.g. IA64, SH.

Yes, it would be a false positive. If I understand correctly, right now we error due to an assertion. So after your patch, if someone (for whatever reason) has a different file name, we would error anyway in the same way we error now, via the same assertion right? If we error anyway, feel like it could be marginally more helpful to make the error location/message as precise as possible.

That said, I don't know this area nor vDSO very well, so I'm not sure if my proposal is very canonical. I'm just brainstorming from the perspective of someone who wants to make debugging as straightforward as possible. I'm happy to approve the change as-is. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28102#issuecomment-3485834347


More information about the hotspot-dev mailing list