RFR: 8367656: Refactor Constantpool's operand array into two [v7]
Coleen Phillimore
coleenp at openjdk.org
Tue Nov 4 13:44:54 UTC 2025
On Tue, 4 Nov 2025 10:49:31 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line 482:
>>
>>> 480: int basePos = offs.at(bsmIndex);
>>> 481: int argv = basePos + INDY_ARGV_OFFSET;
>>> 482: int argc = getBootstrapMethodArgsCount(bsmIndex);
>>
>> Nit: Consider to make it shorter:
>> `getBootstrapMethods` => `getBSMs`
>> `getBootstrapMethodArgsCount` => `getBSMArgsCount`
>
> I'm keeping it verbose, as that's the general style of this file.
Yes please I like the full names if possible rather than abbreviations.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2490567923
More information about the hotspot-dev
mailing list