RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v6]
Johan Sjölen
jsjolen at openjdk.org
Wed Nov 5 05:09:16 UTC 2025
On Tue, 4 Nov 2025 19:07:32 GMT, Nityanand Rai <duke at openjdk.org> wrote:
>> Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs
>
> Nityanand Rai has updated the pull request incrementally with one additional commit since the last revision:
>
> minor refactoring to reduce code duplication
Changes requested by jsjolen (Reviewer).
test/hotspot/gtest/runtime/test_os.cpp line 744:
> 742: EXPECT_TRUE(GtestUtils::is_memory_tagged_as_java(p, 1 * M))
> 743: << "JVM memory allocated via os::reserve_memory should be tagged with VM_MEMORY_JAVA on macOS";
> 744: #endif
Move all of these snippets into one separate test
-------------
PR Review: https://git.openjdk.org/jdk/pull/27868#pullrequestreview-3419863275
PR Review Comment: https://git.openjdk.org/jdk/pull/27868#discussion_r2492971686
More information about the hotspot-dev
mailing list