RFR: 8367982: Unify ObjectSynchronizer and LightweightSynchronizer [v5]

Fredrik Bredberg fbredberg at openjdk.org
Thu Nov 6 12:19:20 UTC 2025


On Wed, 5 Nov 2025 17:35:16 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

>> This is the last PR in a series of PRs (see: [JDK-8344261](https://bugs.openjdk.org/browse/JDK-8344261)) to obsolete the LockingMode flag and related code.
>> 
>> The main focus is to to unify `ObjectSynchronizer` and `LightweightSynchronizer`.
>> There used to be a number of "dispatch functions" to redirect calls depending on the setting of the `LockingMode` flag.
>> Since we now only have lightweight locking, there is no longer any need for those dispatch functions, so I removed them.
>> To remove the dispatch functions I renamed the corresponding lightweight functions and call them directly.
>> This ultimately led me to remove "lightweight" from the function names and go back to "fast" instead, just to avoid having some with, and some without the "lightweight" part of the name.
>> 
>> This PR also include a small simplification of `ObjectSynchronizer::FastHashCode`.
>> 
>> Tested tier1-7 (on supported platforms) without seeing any problems that can be traced to this code change.
>> All other platforms (`arm`, `ppc`, `riscv`, `s390`) has been sanity checked using QEMU.
>
> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' into 8367982_unify_object_and_lightweight_synchronizer
>  - Merge branch 'master' into 8367982_unify_object_and_lightweight_synchronizer
>  - Update two, after the review
>  - Update after review
>  - Small arm32 fix
>  - Small include line fix
>  - 8367982: Unify ObjectSynchronizer and LightweightSynchronizer

Thank you for the reviews. Now let's...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27915#issuecomment-3496959325


More information about the hotspot-dev mailing list