RFR: 8358957: [ubsan]: The assert in layout_helper_boolean_diffbit() in klass.hpp needs UB to fail [v5]

Afshin Zafari azafari at openjdk.org
Fri Nov 7 11:07:56 UTC 2025


On Fri, 7 Nov 2025 10:14:06 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments applied
>
> src/hotspot/share/oops/klass.hpp line 524:
> 
>> 522:     // Use well known bit hack to isolate the low bit of candidates.
>> 523:     // The usual form is (x & -x), but VS warns (C4146) about unary minus of unsigned.
>> 524:     // So use alternate form of negation to avoid warning.
> 
> "So explicitly use two's complement to avoid warning"

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27288#discussion_r2502823874


More information about the hotspot-dev mailing list