RFR: 8371418: Methods in AdapterHandlerLibrary use HashtableBase iterate method incorrectly [v2]
Ashutosh Mehra
asmehra at openjdk.org
Fri Nov 7 19:38:04 UTC 2025
On Fri, 7 Nov 2025 16:38:54 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> do you know what issue current code (before these changes) could cause?
`AdapterHandlerLibrary::print_handler_on` is called from `os::print_location() -> codeBlob::dump_for_addr()`.
`os::print_location()` is only used in error reporting to print the location of the address.
With the current code (before this patch) `AdapterHandlerLibrary::print_handler_on` could have returned without printing anything, even if the `CodeBlob` passed as parameter is of type `AdapterBlob`. In debug builds it could also trigger the assert:
assert(found, "Should have found handler");
btw the change that introduced this bug was made more than 3 years ago in https://bugs.openjdk.org/browse/JDK-8292384 and it went in JDK 20.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28197#issuecomment-3504526393
More information about the hotspot-dev
mailing list