RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v9]
Paul Hohensee
phh at openjdk.org
Fri Nov 7 22:13:07 UTC 2025
On Fri, 7 Nov 2025 05:08:20 GMT, Nityanand Rai <duke at openjdk.org> wrote:
>> Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs
>
> Nityanand Rai has updated the pull request incrementally with one additional commit since the last revision:
>
> remove blanck line
Changes requested by phh (Reviewer).
src/hotspot/os/bsd/os_bsd.cpp line 107:
> 105: #include <mach/task_info.h>
> 106: #include <mach-o/dyld.h>
> 107: #include <mach/vm_statistics.h>
You don't need this here because you included it in os_bsd.hpp.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27868#pullrequestreview-3436641793
PR Review Comment: https://git.openjdk.org/jdk/pull/27868#discussion_r2505700791
More information about the hotspot-dev
mailing list