RFR: 8357579: Compilation error: first argument in call to 'memset' is a pointer to non-trivially copyable type [v11]

[Jan Kratochvil]

On Mon, 10 Nov 2025 04:28:02 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove the sizeof == const assertions
>
> src/hotspot/share/oops/resolvedFieldEntry.hpp line 47:
> 
>> 45: 
>> 46: // Verify no compiler paddings are present, check STATIC_ASSERTs in the .cpp file.
>> 47: 
> 
> I think this comment is not necessary.

I have removed it, but I disagree, as there’s no way to make such a foolproof assertion in C++.

> src/hotspot/share/oops/resolvedMethodEntry.hpp line 65:
> 
>> 63: 
>> 64: // Verify no compiler paddings are present, check STATIC_ASSERTs in the .cpp file.
>> 65: 
> 
> Comment not necessary.

I have removed it, but I disagree, as there’s no way to make such a foolproof assertion in C++.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26098#discussion_r2508742761
PR Review Comment: https://git.openjdk.org/jdk/pull/26098#discussion_r2508742947