RFR: 8371418: Methods in AdapterHandlerLibrary use HashtableBase iterate method incorrectly [v2]

Ashutosh Mehra asmehra at openjdk.org
Mon Nov 10 14:53:39 UTC 2025


On Mon, 10 Nov 2025 13:29:10 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comments
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Looks good

@adinn thanks for the review. I will fix the comment as suggested.

> src/hotspot/share/classfile/compactHashtable.hpp line 297:
> 
>> 295:   }
>> 296: 
>> 297:   // Iterate through the values in the table, stopping when do_value() return false.
> 
> Suggestion:
> 
>   // Iterate through the values in the table, stopping when do_value() return false.
> 
>   // Iterate through the values in the table, stopping when iter->do_value() returns false.

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28197#issuecomment-3512165594
PR Review Comment: https://git.openjdk.org/jdk/pull/28197#discussion_r2510861828


More information about the hotspot-dev mailing list