RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v10]
Evgeny Astigeevich
eastigeevich at openjdk.org
Mon Nov 10 18:48:00 UTC 2025
On Sat, 8 Nov 2025 00:05:38 GMT, Nityanand Rai <duke at openjdk.org> wrote:
>> Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs
>
> Nityanand Rai has updated the pull request incrementally with one additional commit since the last revision:
>
> remove unncessary included
test/hotspot/gtest/testutils.cpp line 94:
> 92: if (address <= (mach_vm_address_t)addr &&
> 93: (address + region_size) >= ((mach_vm_address_t)addr + size)) {
> 94: // Check if the user_tag matches VM_MEMORY_JAVA
No need this comment because it just repeats what is written in `return`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27868#discussion_r2511602937
More information about the hotspot-dev
mailing list